Initial file structure - Githubissues

redhat-qe-security / SCAutolib

Library for automation of smart card testing

GNU General Public License v3.0

3 stars 10 forks source link

Initial file structure #57

Closed x00Pavel closed 2 years ago

x00Pavel commented 2 years ago

PR contains the initial file structure for SCAutolib python package including documentation set, CI, and packaging configuration.

lgtm-com[bot] commented 2 years ago

This pull request fixes 6 alerts when merging b0ce62b47a9e5053b9631be13f67cde25dbc52fe into 8d3ab775fe1835ed7e27b971e729251d8237dd04 - view on LGTM.com

fixed alerts:

2 for Except block handles 'BaseException'
2 for Module is imported with 'import' and 'import from'
2 for Clear-text storage of sensitive information

inikolcev commented 2 years ago

Also, in the future please use even smaller PRs. For example you could separate the changes around logging and documentation. The PR is

lgtm-com[bot] commented 2 years ago

This pull request fixes 6 alerts when merging 8cb4ebebeccf10090386b14fb7db6a50ba5da364 into 8d3ab775fe1835ed7e27b971e729251d8237dd04 - view on LGTM.com

fixed alerts:

2 for Except block handles 'BaseException'
2 for Module is imported with 'import' and 'import from'
2 for Clear-text storage of sensitive information

mahavrila commented 2 years ago

I agree with Ivan that this PR should ideally contain separate commits for 1) documentation generation, 2) setup of unit tests in CI, 3) adding initial structure and maybe populating init with code could also be separate commit.

x00Pavel commented 2 years ago

I would prefer to squash all commits in PR as PR by itself should be smaller than even that one. So, one squashed commit would represent one change.

lgtm-com[bot] commented 2 years ago

This pull request fixes 6 alerts when merging 2300a3691395e1217e26b8189090f81e8cb9db7c into 8d3ab775fe1835ed7e27b971e729251d8237dd04 - view on LGTM.com

fixed alerts:

2 for Except block handles 'BaseException'
2 for Module is imported with 'import' and 'import from'
2 for Clear-text storage of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request fixes 6 alerts when merging 0729d0b87880d160dd36b23c2b797a34af13fa2c into 8d3ab775fe1835ed7e27b971e729251d8237dd04 - view on LGTM.com

fixed alerts:

2 for Except block handles 'BaseException'
2 for Module is imported with 'import' and 'import from'
2 for Clear-text storage of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request fixes 6 alerts when merging 09bf289ebb21e32d2b1534bf75ffff38590aacc8 into 8d3ab775fe1835ed7e27b971e729251d8237dd04 - view on LGTM.com

fixed alerts:

2 for Except block handles 'BaseException'
2 for Module is imported with 'import' and 'import from'
2 for Clear-text storage of sensitive information