redhat-qe-security / SCAutolib

Library for automation of smart card testing
GNU General Public License v3.0
3 stars 10 forks source link

Add implementation of File class #60

Closed mahavrila closed 2 years ago

mahavrila commented 2 years ago

General File class, SSSDConf and SoftHSM2Conf classes are added with template files and unit tests. CNF file is yet to be added, but review should not wait for it.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 6f30815b1c80ddc4788a6f07ffd594ef66c7a560 into d01406b7d90e3f7c59b3ca8dac7564b02278fd17 - view on LGTM.com

new alerts:

x00Pavel commented 2 years ago

Another issue is that while installing IPA client, we use IPA script that changes SSSD conf. So, we need a way how to update the default content of the file after this script is completed. Kind of update_default_content() method

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 0fe63af3fc754d28a664ee57a063e104e495e5f4 into d01406b7d90e3f7c59b3ca8dac7564b02278fd17 - view on LGTM.com

new alerts:

mahavrila commented 2 years ago

Another issue is that while installing IPA client, we use IPA script that changes SSSD conf. So, we need a way how to update the default content of the file after this script is completed. Kind of update_default_content() method

This is reflected in recent update of this PR that already contains _update_default_content method.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging 0a43629f3160115620c4280b0aae4bfd18d89aa4 into d01406b7d90e3f7c59b3ca8dac7564b02278fd17 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging a28e16c5b0b2492083a56d2313774b6a76897ce4 into d01406b7d90e3f7c59b3ca8dac7564b02278fd17 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging a142e1c7dbc4d3062b24c094694df5b0d42db41a into d01406b7d90e3f7c59b3ca8dac7564b02278fd17 - view on LGTM.com

new alerts:

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging f969b89b57fcbdf52adbed40efb68245b10707f5 into 0abfd93249404ba6fefde77758dd2d5f9500572e - view on LGTM.com

new alerts:

x00Pavel commented 2 years ago

Closing because this PR is replaced by #64