V2 cards - Githubissues

redhat-qe-security / SCAutolib

Library for automation of smart card testing

GNU General Public License v3.0

3 stars 10 forks source link

V2 cards #65

Closed x00Pavel closed 2 years ago

x00Pavel commented 2 years ago

Implementation of VirtualSmartCard class with Card interface.

No unit test because cards require User, and to not overcomplicate unit tests without Users classes ready, unit tests would be added after required classes are ready

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 44b52a86434af61be6b31ba45836786cb92c06f8 into f80ce4f9139ded51f590498651e6a1ca2a138d4b - view on LGTM.com

new alerts:

1 for Special method has incorrect signature
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 5bb5cf996774da8708ade0fad2a34dbc221bf6b3 into f80ce4f9139ded51f590498651e6a1ca2a138d4b - view on LGTM.com

new alerts:

1 for Special method has incorrect signature
1 for Clear-text logging of sensitive information

x00Pavel commented 2 years ago

@mahavrila Replacing/removing the cert and key on the virtual card is not so simple as replacing corresponding files in the directory. A cert and the key should be replaced in NSS database. But we never tried this before for several reasons. Keeping a cert and a key in the card directory helps us to see what is happening during the tests

The method for destroying the card is a good idea in general and will kind of complete functionality. The reason why there is still no such method is that we don't have real use case for this. But implementation should be easy, so I would leave implementation for the future if it would be needed.

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging ce5afcfce641b002c7b02889eb0bffcdf0818c85 into f80ce4f9139ded51f590498651e6a1ca2a138d4b - view on LGTM.com

new alerts:

1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging a7052acd4e924d47082b80dc54c589d11ead3bbe into d793c2de262d005cdf341083ae35136ad459c6e7 - view on LGTM.com

new alerts:

1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging ba7c492c5dd4a67b4920b359813ccb4fdfb7d567 into 56532e11c6b24a73513cdcd5457744aeacdd1203 - view on LGTM.com

new alerts:

1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 41646d795abb83d452e655c2d19add084301e25a into 56532e11c6b24a73513cdcd5457744aeacdd1203 - view on LGTM.com

new alerts:

1 for Unused import
1 for Clear-text logging of sensitive information

lgtm-com[bot] commented 2 years ago

This pull request introduces 1 alert when merging e43cfa4eea191704e920f50da88242005695f77c into 56532e11c6b24a73513cdcd5457744aeacdd1203 - view on LGTM.com

new alerts:

1 for Clear-text logging of sensitive information