redhat-qe-security / SCAutolib

Library for automation of smart card testing
GNU General Public License v3.0
3 stars 10 forks source link

Add "setup" methods in Controller class #86

Closed x00Pavel closed 1 year ago

x00Pavel commented 1 year ago

This PR is a piece for a bigger PR that brings changes related only to the Controller's methods.

Please, let's make this PR purely technical and do not fix docstrings or other cosmetical stuff in this PR if it is missing. For this let's do separate PR with just documentation stuff. Just create the issue for your request and add documentation labels or another label if it would be applicable.

There is the method dump_to_json(object) that is not present in this PR. It would be introduced in future PR's when the corresponding feature for dumping the objects to JSON would be introduced

Resolved issues:

x00Pavel commented 1 year ago

@ep69 As it is written in the PR description, this is just a part of the bigger PR I made by mistake. So to make the PR more consumable, I tried to split it into some logical parts (that made sense for me), e.g this PR is related directly to the Controller class and brings changes mostly in it without touching other classes. Here it is important for to review the logic of the Controller by itself without looking into other parts because this was the reason why enormous "parent" PR appeared.

Following PRs will bring fixes and functionality in other classes.

x00Pavel commented 1 year ago

All typos/grammar issues/docstrings issues are referenced in issues with documentation label

x00Pavel commented 1 year ago

Linting would be solved in the next PR along with documentation and grammar fixes