RCUE: Pager & Pagination Components added

[suzidao]

Hi Robb,

Here are the pager and pagination components for RCUE.

• Susanne

Commit Comments: Added pagination test page Pager style updates Pagination refinement Small size and various states Pagination hover bug fix attempt Pagination hover bug fix attempt: removed extraneous .button-variant mixins Pagination hover bug fix - final Pager disabled active bug fix Pagination - added small pager styles Pagination - added headers to sample page Cross-browser edits

[rhamilto]

Thanks, Susanne. On first glance, I notice you're redefining the value of the @padding-small-vertical variable. That's problematic as that variable is used by other components (buttons, input-groups, etc.). Please create a custom variable for use in pagination. Thanks!

[suzidao]

Hi Robb, I've rolled back the @padding-small-vertical variable and added @pagination-padding-small-vertical. Please let me know if there are any more discrepancies. This is my first time using GitHub and I'm still trying to get the hang of the workflow. You may notice a few Modal Window-related edits in this branch; I began work on that before I remembered that you wanted individual branches for each component. I'll have that one done later tonight.

[rhamilto]

Thanks, Susanne. I didn't notice the modal changes, but can you remove anything related to modals so it can go in its own pull request? Thanks.

[suzidao]

Hi Robb, all modal changes have been removed. I'll submit the modal pull request shortly.

[rhamilto]

Hi, Susanne.

Sorry for the delay in getting this reviewed. I've been busy trying to get the PatternFly site up!

Can you please make the following changes:

• pager.less
  • alphabetize declarations by property or mixin name;
  • line 55 has .box-shadow(0 0px 0px rgba(0,0,0,0)); that's a box-shadow of nothing. are you trying to unset the existing box shadow? if so, that should be .box-shadow(none);
• pagination.less
  • alphabetize declarations by property or mixin name
• variables.less
  • correct alphabetization of added variables
• pagination.html
  • cleanup the html formatting so it's "pretty" (all sibling nodes align)

Sorry for not providing clear direction on the coding standards! I will document them in the readme.

Thanks, Robb.

[suzidao]

Hi Robb,

I've updated the pager and pagination files to comply with coding standards. Please let me know if further changes are needed.

Thanks, Susanne