search

redhat-rcue / rcue

Red Hat Common User Interface (RCUE) reference implementation
Other
26 stars 16 forks source link

bower.json: use devDependencies instead of dependencies to allow consuming RCUE as a bower package #4

Closed lfryc closed 10 years ago

lfryc commented 10 years ago

Related to bootstrap-3 branch:

I suggest to use devDependencies instead of dependencies:

https://github.com/rhamilto/rcue/blob/master/bower.json#L15

The reason is that when you download a package which specifies dependencies, all that dependencies needs to be downloaded as well.

I don't think people that will use RCUE style directly needs sources of third-party dependencies that RCUE builds upon.

rhamilto commented 10 years ago

Thanks for the suggestion, Lukas!

I've opted to include them as dependencies because there are files included in those dependencies that RCUE relies upon (e.g., the icon font in Bootstrap). Were you thinking RCUE was only the LESS and its rendered CSS?

lfryc commented 10 years ago

That make sense Robb.

Resolution could be copiying all the required files to /dist. We went through this in https://github.com/richwidgets/richwidgets project.

Anyway I haven't though about that aspect, so you can probably leave it as it is.

I assume all of those dependencies are needed for project users, so it's not worth to kick any of them out, right?

rhamilto commented 10 years ago

Yeah, I'm inclined to leave things as is for simplicity's sake.

Yeah, all of those dependencies are required for RCUE since RCUE is to support IE8.