search

redhat-rcue / rcue

Red Hat Common User Interface (RCUE) reference implementation
Other
26 stars 16 forks source link

Added explicit dependencies #64

Closed dlabrecq closed 7 years ago

dlabrecq commented 7 years ago

Added explicit dependencies so npm will create a flat node_modules structure.

During a release, the npm-shrinkwrap file is removed in order to create a new file with the latest dependencies. In this scenario, npm install places dependencies under node_modules/patternfly/node_modules, which prevents the build from succeeding. Creating explicit dependencies forces dependencies to be placed in the root node_modules directory where patternfly expects them to be.

This will allow me to remove my workaround to manually move dependencies from node_modules/patternfly/node_modules to node_modules.

dtaylor113 commented 7 years ago

LGTM! This seems to already be in place in patternfly, but #550 indicates that the dependencies are NOT being placed in the root of 'node_modules'. -thanks

dlabrecq commented 7 years ago

Merging... The RCUE release build is failing without this change.