search

redhat-rcue / rcue

Red Hat Common User Interface (RCUE) reference implementation
Other
26 stars 15 forks source link

Alignment issues with wizard on RCUE 3.23 (does not affect PatternFly 3.23) #69

Closed jawnsy closed 7 years ago

jawnsy commented 7 years ago

Hi,

There seems to be a strange alignment problem with the wizard steps indicator. Inexplicably, it only affects RCUE 3.23 and does not affect PatternFly 3.23.

PatternFly 3.23 - http://codepen.io/anon/pen/ryqzpj

screenshot from 2017-03-28 14-03-48

RCUE 3.23 - http://codepen.io/anon/pen/MpPvOe

screenshot from 2017-03-28 14-03-51

jawnsy commented 7 years ago

@andresgalante suggested checking the latest RCUE (3.23.1) and unfortunately the problem still exists there too. I need to get some other stuff merged first but will do some more investigation next week.

screenshot from 2017-03-30 15-25-41

Updated codepen: http://codepen.io/jawnsy/pen/BWvjzx

I've confirmed that patternfly.version from the console reports 3.23.1

andresgalante commented 7 years ago

Thanks for reporting this, I could reproduce the bug. I'll look into it.

andresgalante commented 7 years ago

The issue is on wizard-pf-step-number. It should be left: calc(50% - 13px) instead of 37px.

andresgalante commented 7 years ago

Solution: Escape calc so less doesn't compile it. ~"calc(50% - 13px)";

@jawnsy I'll fix this on patternfly, when do you need it on RCUE? can it wait till next release in 2 weeks?

@srambach please check this one out, for next time we do calc :)

jawnsy commented 7 years ago

Thanks for the quick fix! There's no urgency on our end, we can wait until the next release; we'll just stay on PatternFly in the meantime.