jawnsy
commented
7 years ago Tested this using:
-
Local build of rcue (this branch)
$ bundle exec grunt Running "copy:main" (copy) task Created 1 directory, copied 76 files Running "jekyll:tests" (jekyll) task `jekyll build --source node_modules/patternfly/tests/pages --destination tests --config _config.yml` was initiated. Configuration file: _config.yml Source: node_modules/patternfly/tests/pages Destination: tests Incremental build: disabled. Enable with --incremental Generating... done in 0.779 seconds. Auto-regeneration: disabled. Use --watch to enable. Running "less:rcue" (less) task >> 1 stylesheet created. >> 1 sourcemap created. Running "less:rcueAdditions" (less) task >> 1 stylesheet created. >> 1 sourcemap created. Running "cssmin:production" (cssmin) task >> 2 sourcemaps created. >> 2 files created. 416.48 kB → 340.8 kB Running "csscount:production" (csscount) task dist/css/rcue-additions.min.css Selectors: 2144 | Declr: 3290 | Rules: 1362 | S/R: 1.6 | D/R: 2.4 || 163k (23k gzip) | D1: 436 (20%) | D2: 625 (29%) | D3: 405 (19%) | D4: 360 (17%) | D5: 243 (11%) | D6: 65 (3%) | D7: 4 (0%) | D8: 6 (0%) || * 16 dist/css/rcue.min.css Selectors: 3939 | Declr: 3668 | Rules: 2281 | S/R: 1.7 | D/R: 1.6 || 178k (31k gzip) | D1: 2378 (60%) | D2: 1185 (30%) | D3: 322 (8%) | D4: 33 (1%) | D5: 21 (1%) || * 6 Done, without errors. $ npm link npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree. > patternfly@3.25.0 postinstall /home/jawnsy/projects/rcue/node_modules/patternfly > npm run jekyll > patternfly@3.25.0 jekyll /home/jawnsy/projects/rcue/node_modules/patternfly > ruby --version || echo "Ruby required"; gem install bundler; bundle install; set -e ruby 2.3.3p222 (2016-11-21 revision 56859) [x86_64-linux] Successfully installed bundler-1.15.1 Parsing documentation for bundler-1.15.1 Done installing documentation for bundler after 6 seconds 1 gem installed Using addressable 2.4.0 Using colorator 1.1.0 Using sass 3.4.22 Using rb-fsevent 0.9.8 Using ffi 1.9.14 Using kramdown 1.12.0 Using liquid 3.0.6 Using mercenary 0.3.6 Using forwardable-extended 2.6.0 Using rouge 1.11.1 Using safe_yaml 1.0.4 Using bundler 1.15.1 Using jekyll-sass-converter 1.4.0 Using rb-inotify 0.9.7 Using pathutil 0.14.0 Using listen 3.0.8 Using jekyll-watch 1.5.0 Using jekyll 3.3.0 Bundle complete! 1 Gemfile dependency, 18 gems now installed. Use `bundle info [gemname]` to see where a bundled gem is installed. - buffer-shims@1.0.0 node_modules/buffer-shims - jodid25519@1.0.2 node_modules/jodid25519 - moment@2.8.4 node_modules/patternfly/node_modules/eonasdan-bootstrap-datetimepicker/node_modules/moment - lodash@3.10.1 node_modules/grunt-run/node_modules/lodash - grunt-run@0.6.0 node_modules/grunt-run - datatables@1.10.13 node_modules/patternfly/node_modules/datatables rcue@3.25.0 /home/jawnsy/projects/rcue ├─┬ grunt-contrib-connect@0.5.0 │ └─┬ connect@2.7.11 │ └─┬ debug@2.6.8 │ └── ms@2.0.0 ├─┬ grunt-contrib-cssmin@0.12.3 │ ├── clean-css@3.4.27 │ └─┬ maxmin@1.1.0 │ ├─┬ gzip-size@1.0.0 │ │ └─┬ concat-stream@1.6.0 │ │ └─┬ readable-stream@2.2.11 │ │ └── string_decoder@1.0.2 │ └─┬ pretty-bytes@1.0.4 │ └─┬ meow@3.7.0 │ └─┬ normalize-package-data@2.3.8 │ └── hosted-git-info@2.4.2 ├─┬ grunt-contrib-less@1.4.1 │ ├── async@2.4.1 │ └─┬ less@2.7.2 │ ├── image-size@0.5.5 │ ├── promise@7.2.0 │ └─┬ request@2.81.0 │ ├── extend@3.0.1 │ ├── form-data@2.1.4 │ ├─┬ har-validator@4.2.1 │ │ └── ajv@4.11.8 │ └─┬ http-signature@1.1.1 │ └─┬ sshpk@1.13.1 │ └── getpass@0.1.7 ├─┬ grunt-css-count@0.3.2 │ └─┬ glob@7.1.2 │ └─┬ minimatch@3.0.4 │ └─┬ brace-expansion@1.1.8 │ └── balanced-match@1.0.0 ├─┬ patternfly@3.25.0 │ ├── bootstrap-select@1.12.2 │ ├── bootstrap-switch@3.3.4 │ ├── datatables.net@1.10.15 │ ├── datatables.net-bs@1.10.15 │ ├── datatables.net-colreorder@1.3.3 │ ├── datatables.net-colreorder-bs@1.3.3 │ ├── datatables.net-select@1.2.2 │ ├── eonasdan-bootstrap-datetimepicker@4.17.47 │ ├── font-awesome@4.7.0 │ ├── jquery@3.2.1 │ ├── jquery-match-height@0.7.2 │ ├── moment-timezone@0.4.1 │ └── patternfly-bootstrap-treeview@2.1.3 └── patternfly-eng-release@3.25.1 /home/jawnsy/.npm-packages/lib/node_modules/rcue -> /home/jawnsy/projects/rcue -
Updated package dependency in my project to rcue 3.25.0
-
Verified that the locally-built version was used
$ sha1sum ~/projects/online/src/github.com/openshift/online/accountant/assets/static/components/rcue/dist/css/rcue.min.css 052b8406b1c0713722a76812111f956a85284f86 /home/jawnsy/projects/online/src/github.com/openshift/online/accountant/assets/static/components/rcue/dist/css/rcue.min.css $ sha1sum ~/projects/rcue/dist/css/rcue.min.css 052b8406b1c0713722a76812111f956a85284f86 /home/jawnsy/projects/rcue/dist/css/rcue.min.css
Screenshot - the steps are fixed now:
@bleathem @andresgalante @jawnsy, please review.
FYI, all the calc() in patternfly work well.