search

redhat-scholars / istio-tutorial

Istio Tutorial for https://dn.dev/master
https://redhat-scholars.github.io/istio-tutorial/
Apache License 2.0
1.21k stars 705 forks source link

Katacoda Impact: HTTP Error makes Katacoda scenario to not display the application or error log #16

Closed rafabene closed 6 years ago

rafabene commented 6 years ago

When the exception is propagated to Customer, it impacts Katacoda as any HTTP response that is not 20x will cause Katacoda to say that the application is not available, thus the steps https://github.com/redhat-developer-demos/istio-tutorial#deploy-customer and https://github.com/redhat-developer-demos/istio-tutorial#deploy-preferences will fail. You can check this behaviour by running the Katacoda scenario https://www.katacoda.com/rafabene/courses/workshop/2-deploy-microservices

rafabene commented 6 years ago

The Step https://github.com/redhat-developer-demos/istio-tutorial#http-error-503 also fails. You can check it running the Scenario https://www.katacoda.com/rafabene/courses/workshop/5-fault-injection

BenHall commented 6 years ago

We're looking at changing this. For certain requests we want to have this behaviour (Openshift dashboard still loading), where as application errors we want to show the error.

burrsutter commented 6 years ago

We need the HTTP error code to be returned from the app as that is what Istio seems to be monitoring for things like circuit-breakers.

kameshsampath commented 6 years ago

yes for Istio circuit breakers to work we need right error codes - in this case HTTP 5xx

BenHall commented 6 years ago

We can change that

On 23 Jan 2018 11:33 am, "Kamesh Sampath" notifications@github.com wrote:

yes for Istio circuit breakers to work we need right error codes - in this case HTTP 5xx

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/redhat-developer-demos/istio-tutorial/issues/16#issuecomment-359763027, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFCtmrJ8qokInnqzLSg-08ts5EYbAcdks5tNcN0gaJpZM4Rlknw .

rafabene commented 6 years ago

@BenHall Giving this discussion and how Istio handles circuit breakers, we need to change that. What's the procedure? Should I report that somewhere?

rafabene commented 6 years ago

@BenHall Do you have any updates on this? Thank you

rafabene commented 6 years ago

Solved in Katacoda. Reference: https://trello.com/c/AjTJfVNc/48-application-error-avoids-katacoda-to-show-its-message