search

redhat-scholars / kubernetes-tutorial

Kubernetes Tutorial for https://dn.dev/master
https://redhat-scholars.github.io/kubernetes-tutorial/
Apache License 2.0
361 stars 194 forks source link

Copy button adds additional 2 LF before and 1 LF after #16

Closed yanaga closed 4 years ago

yanaga commented 4 years ago

Whenever you hit the copy button in the tutorial you get 2 additional LF copied before the block and 1 additional LF after the block. Any chance we can remove this annoyance?

lordofthejars commented 4 years ago

this is some behaviour of the copy to clipboard extension. NowI have developed a pure JS copy to clipboard logic instead of using the extension. When the current PR is merged (I'll do it tomorrow morning) then I'll send another PR that fixes this.

Missatge de Edson Yanaga notifications@github.com del dia dg., 3 de maig 2020 a les 22:13:

Assigned #16 https://github.com/redhat-developer-demos/kubernetes-tutorial/issues/16 to @lordofthejars https://github.com/lordofthejars.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/redhat-developer-demos/kubernetes-tutorial/issues/16#event-3297790811, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALSMYMB5QYJBVXUT4GEHZDRPXF45ANCNFSM4MYIWE2Q .

lordofthejars commented 4 years ago

I think this is fixed with the new version.