search

redhat-scholars / kubernetes-tutorial

Kubernetes Tutorial for https://dn.dev/master
https://redhat-scholars.github.io/kubernetes-tutorial/
Apache License 2.0
362 stars 193 forks source link

Reduce the use of "&&" in the installation section #17

Closed burrsutter closed 4 years ago

burrsutter commented 4 years ago

Joining these commands reduces learnability. It is better for the reader to see, use and attempt to understand the commands individually. Especially commands that need to be repeated if a new terminal window is opened or the laptop rebooted.

As an example: git clone https://github.com/redhat-developer-demos/kubernetes-tutorial kubernetes-tutorial && \ export TUTORIAL_HOME="$(pwd)/kubernetes-tutorial" && \ cd $TUTORIAL_HOME

kameshsampath commented 4 years ago

@lordofthejars this thing comes in the common part of the tutorial, since you are hacking it I leave it to you.

lordofthejars commented 4 years ago

Fixed at commons repo. https://github.com/redhat-developer-demos/rhd-tutorial-common/commit/a6a02696238beaea65b720046a856bda2c3622b4

kameshsampath commented 4 years ago

Thanks Alex

Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Soto notifications@github.com Sent: Thursday, May 7, 2020 11:49:30 AM To: redhat-developer-demos/kubernetes-tutorial kubernetes-tutorial@noreply.github.com Cc: Kamesh Sampath kamesh.sampath@hotmail.com; Assign assign@noreply.github.com Subject: Re: [redhat-developer-demos/kubernetes-tutorial] Reduce the use of "&&" in the installation section (#17)

Fixed at commons repo. redhat-developer-demos/rhd-tutorial-common@a6a0269https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fredhat-developer-demos%2Frhd-tutorial-common%2Fcommit%2Fa6a02696238beaea65b720046a856bda2c3622b4&data=02%7C01%7C%7Cc5a6d8009d7d47b7d81808d7f24e9a19%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637244291708432919&sdata=e3sLTtWfq6BCiyxQrc1WymD%2BixogLyifT3zb3D8NoFI%3D&reserved=0

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fredhat-developer-demos%2Fkubernetes-tutorial%2Fissues%2F17%23issuecomment-625052764&data=02%7C01%7C%7Cc5a6d8009d7d47b7d81808d7f24e9a19%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637244291708442913&sdata=nz7FnbDPZDTO7ATQcZdKpvCf3kpYT1A%2BfMfUXMMeRW8%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHHMIOKLRQLO5YZLUNE4XTRQJHHFANCNFSM4M2NKWQQ&data=02%7C01%7C%7Cc5a6d8009d7d47b7d81808d7f24e9a19%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637244291708442913&sdata=l1%2BwT7Xzzc%2BDaapdH2e7WhNu5GNxShwOKg87e6ZvjuU%3D&reserved=0.