search

redhataccess / ascii_binder

AsciiBinder is an AsciiDoc-based system for authoring and publishing closely related documentation sets from a single source.
https://asciibinder.net
MIT License
76 stars 39 forks source link

Do we still allow .adoc extensions in _topic_map.yml #105

Closed bexelbie closed 7 years ago

bexelbie commented 7 years ago

https://github.com/redhataccess/ascii_binder/blob/64d2e7e41e9165f343603bfc2639547d05d8256c/templates/_topic_map.yml#L10

It appears this line is incorrect and that file names should NOT include in the .adoc extension, even optionally.

Is this desired behavior?

bexelbie commented 7 years ago

This may actually be a bug in this line:

https://github.com/redhataccess/ascii_binder/blob/master/lib/ascii_binder/topic_entity.rb#L36

Should it really read:

this_step = file.end_with?('.adoc') ? file : "#{file}.adoc"

nhr commented 7 years ago

Good catch; fixed in https://github.com/redhataccess/ascii_binder/pull/110