Hey @nhr - not sure if you are still looking at this but I have changed the default depth to 3 instead of 2 due to the many products building on top of OpenShift and the need to be able to define navigation for them at a deeper level.
All this PR does is make it the default instead of 2.
I know that:
I can set the toc_depth=3 instead of making 3 the default. But that would require everyone who builds with asciibinder to set that at the command line, which is a bit of a pain.
The OpenShift docs will need to change their navigation template to support a depth of 3. I have a PR in progress for this.
If you have no objections to it, I will merge it later tomorrow and then publish the gem.
nhr
commented
5 years ago
Hey @nhr - not sure if you are still looking at this but I have changed the default depth to 3 instead of 2 due to the many products building on top of OpenShift and the need to be able to define navigation for them at a deeper level.
All this PR does is make it the default instead of 2.
I know that:
I can set the toc_depth=3 instead of making 3 the default. But that would require everyone who builds with asciibinder to set that at the command line, which is a bit of a pain.
The OpenShift docs will need to change their navigation template to support a depth of 3. I have a PR in progress for this.
If you have no objections to it, I will merge it later tomorrow and then publish the gem.