search

redhataccess / ascii_binder

AsciiBinder is an AsciiDoc-based system for authoring and publishing closely related documentation sets from a single source.
https://asciibinder.net
MIT License
76 stars 39 forks source link

Fixes for issues #44 and #45 #49

Closed nhr closed 8 years ago

nhr commented 8 years ago

This fix addresses issues https://github.com/redhataccess/ascii_binder/issues/44 and https://github.com/redhataccess/ascii_binder/issues/45. Additionally it corrects a bug introduced with pull request https://github.com/redhataccess/ascii_binder/pull/43 and enforces AsciiDoctor 1.5.4 as the required base version.

@Fryguy, @tnguyen-rh, @adellape, @lnewson, @vikram-redhat - please have a look.

lnewson commented 8 years ago

:+1: Looks good to me, thanks Harrison!

Edit: Did some testing using the Openshift Docs, using various title heading markup with ids and even tested using markup such as bold text in the title and it all worked as I'd expect. Also tried removing the :data-uri: attribute in a few files and the images were always displayed in the output :)

Fryguy commented 8 years ago

:+1:

tnguyen-rh commented 8 years ago

@nhr Thanks. I now know a little bit more about Ruby method calls and will avoid adding a space between the method name and the open-paren. I think space-after-comma in the arglist aids readability, but if the rest of AsciiBinder doesn't do that, i'll follow suit.