search

redhataccess / foreman-plugin

Container for Foreman Plugin
13 stars 20 forks source link

Rename gem to foreman_redhat_access #22

Open ekohl opened 6 years ago

ekohl commented 6 years ago

The foreman plugin convention is foreman_<name>. Things are easier when this convention is followed. This mostly noticeable in the code needed in the installer, but just the visual aspect and searching for plugins in directories is easier.

lphiri commented 6 years ago

I would like to rename the plugin for other reasons as well, but this is a non-trivial change due to the ripple effects to downstream packaging.

ares commented 6 years ago

I'm not a packaging expert, but is there other problem than just adding Obsoletes definition to the spec? We needed to do similar thing when we renamed SCL. I think we should start working on that as part of transition to theforeman org. But meanwhile we can ship the plugin with current name.

ekohl commented 6 years ago

On the packaging side you can add Obsoletes so yum automatically migrates you to the new version without human interaction. I agree this doesn't have to be a blocker, we could even already package it with the new name and right provides. That would simplify the installer work a lot, though fixing https://github.com/redhataccess/foreman-plugin/issues/20 would probably also be good to do before integrating it in the installer.

lphiri commented 6 years ago

There is a bit of history that complicates things. The plugin is actually 2 plugins - there is the original "access" part, which provided the ability to manage support cases in the UI etc, and the the "Insights" part.
The right thing to do is to migrate the Insights functionality to a separate gem and corresponding rpm, and I would like do this before renaming anything.

ekohl commented 6 years ago

That's good to know and in that case we should continue with packaging as it is now.