search

redhataccess / foreman-plugin

Container for Foreman Plugin
13 stars 20 forks source link

Fixes #47 - Use import for assets instead of require #51

Closed ehelms closed 4 years ago

ShimShtein commented 4 years ago

Doesn't @import require webpack? I think it won't compile with older assets model.

ehelms commented 4 years ago

The @import is an SCSS construct that can be used here. You can check the blurb in this section -- https://guides.rubyonrails.org/asset_pipeline.html#manifest-files-and-directives

As soon as an updated build of Katello goes through, you'll be able to see this patch working over here -- https://github.com/theforeman/foreman-packaging/pull/5749

ehelms commented 4 years ago

@ShimShtein If you can take a look at the referenced PR for packaging that shows it now builds correctly. If you want to take it for a spin you can install the scratch RPM. Effectively, all new builds of this plugin are blocked on this issue.

ShimShtein commented 4 years ago

@rexwhite, I'm OK with this change. leaving this to up to you to check if the css is applied correctly.

ehelms commented 4 years ago

Thanks! @rexwhite when might we expect a release with this fix in it?

rexwhite commented 4 years ago

I published redhat_access-2.2.17.gem with these changes about 2 minutes ago :-)