search

redhataccess / foreman-plugin

Container for Foreman Plugin
13 stars 20 forks source link

Remove endpoints for proxying payload #56

Closed xprazak2 closed 3 years ago

xprazak2 commented 3 years ago

Contains #50 and #55 in a single branch for easier testing.

ShimShtein commented 3 years ago

Registered a host with this PR and everything worked as expected.

:+1: from me.

lphiri commented 3 years ago

@ShimShtein did your test include checking that the host appears in the old plugin UI?

ShimShtein commented 3 years ago

@lphiri, thanks for pointing this out. This one behaves as expected, but its rh_cloud counterpart (https://github.com/theforeman/foreman_rh_cloud/pull/412) breaks the old plugin. I have left comments there.

ShimShtein commented 3 years ago

@lphiri, I have acked rh_cloud counterpart, it looks like now both plugins can coexist. Would you mind giving it a spin before I merge?

lphiri commented 3 years ago

@rexwhite - can you take a look please?

rexwhite commented 3 years ago

This all looks good, we just need to be mindful when packaging this change to require the appropriate corresponding changes to Foreman for each version of Satellite that gets this update.

rexwhite commented 3 years ago

I just published redhat_access-2.2.19.gem with this fix.