search

redhataccess / pantheon-cmd

Pantheon CMD is an open source and freely distributed program for validating and building local previews of modular documentation.
GNU General Public License v3.0
2 stars 5 forks source link

Validation for pr #19

Closed Levi-Leah closed 3 years ago

Levi-Leah commented 3 years ago

@adahms this is the proof of concept MR validator. rn it's just a bash script that gathers the files and categorizes them as modules/assemblies. There's also a python wrapper that imports those file names from bash and supplies them to the validation script, and prints the output. There's probably a better way of doing this but it's a start. If you have the capacity for a code review, I'd greatly appreciate it.

EDIT: Andrew, can you confirm that all teams are using assemblies/modules directory to store the files? In which case instead of determining if the file is a module or an assembly by looking at prefixes/tags inside the file I can just check if the file path has modules/ or assemblies/ directory

Levi-Leah commented 3 years ago

@adahms I rewrote the PR validator into python. Would you mind taking a look?