search

redhataccess / pantheon-cmd

Pantheon CMD is an open source and freely distributed program for validating and building local previews of modular documentation.
GNU General Public License v3.0
2 stars 5 forks source link

levi-makesh-suggestions #3

Closed Levi-Leah closed 3 years ago

Levi-Leah commented 3 years ago

demonstrated on the example.sh

Levi-Leah commented 3 years ago

@adahms I couldn't comment/make multi-line suggestions properly on your pull request due to some gitlab glitch so I created my own.

These are some suggestion, feel free to implement some or none. I generally focused on trying to eliminate movement between directories and trying to add some error-handling. There are some suggestions on reducing some commands to one-liners, but it's a preference

adahms commented 3 years ago

Thanks for the PR, @Levi-Le - tested on my machine, and LGTM!

Merging. :)