search

redhataccess / pantheon-cmd

Pantheon CMD is an open source and freely distributed program for validating and building local previews of modular documentation.
GNU General Public License v3.0
2 stars 5 forks source link

adds checks for icons and toc attributes #36

Closed Levi-Leah closed 3 years ago

Levi-Leah commented 3 years ago

@adahms this should throw errors for icons and toc attributes

Levi-Leah commented 3 years ago

@adahms Can you clarify about the inclusion of these attributes in the pv2.yml? Do you mean if files that contain these attributes are part of pv2.yml?

adahms commented 3 years ago

@Levi-Leah - Gah, sorry - not the pantheon2.yml file, but the attributes file. ><

Levi-Leah commented 3 years ago

@adahms right now I don’t parse attributes file for anything related to the checks but it should be easy to set up. That being said, if none of the modules/assemblies actually call for these attributes, would flagging it in the attributes file be necessary? Would having in attributes file break smth?

adahms commented 3 years ago

@Levi-Leah - very true. Perhaps the only thing I'm worried about are these attributes that change the structure of the document. Anything a user specifies in the pantheon2.yml file gets injected into every assembly and module, meaning that if a user specifies the 'toc' attribute there, everything gets it.

Levi-Leah commented 3 years ago

@adahms I added toc/icons validation for the attributes file. please take a look when you get the time