redhataccess / pantheon-cmd

Pantheon CMD is an open source and freely distributed program for validating and building local previews of modular documentation.
GNU General Public License v3.0
2 stars 5 forks source link

Issue_58 - Add support for conditions #59

Open adahms opened 2 years ago

adahms commented 2 years ago

Hey @Levi-Leah - could you review this one?

This PR adds supports for ifdef and ifndef conditions when parsing global attributes and coalescing files.

It also addresses the following edge cases -

Levi-Leah commented 2 years ago

@adahms I added a few suggestions regarding the simplification of some if statements, please take them with a grain of salt

adahms commented 2 years ago

Hey @Levi-Leah - finally returning to this one.

I was definitely tying myself up in knots a bit there - I've accepted several of your suggestions and re-worked the logic so that it's a little easier to read and parse.

Let me know what you think if you've got the time for a review. :)

Levi-Leah commented 2 years ago

I'll try to finish the review this week