Open adahms opened 2 years ago
@adahms I added a few suggestions regarding the simplification of some if statements, please take them with a grain of salt
Hey @Levi-Leah - finally returning to this one.
I was definitely tying myself up in knots a bit there - I've accepted several of your suggestions and re-worked the logic so that it's a little easier to read and parse.
Let me know what you think if you've got the time for a review. :)
I'll try to finish the review this week
Hey @Levi-Leah - could you review this one?
This PR adds supports for ifdef and ifndef conditions when parsing global attributes and coalescing files.
It also addresses the following edge cases -