redhatcloudx / transformer

Find RHEL images in public clouds
Apache License 2.0
6 stars 3 forks source link

V2 list provider by OS #590 #686

Closed miyunari closed 1 year ago

miyunari commented 1 year ago

closes #590

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 90.47% and project coverage change: -0.07% :warning:

Comparison is base (0cf01a3) 92.11% compared to head (8a1575f) 92.04%.

:exclamation: Current head 8a1575f differs from pull request most recent head 4bd8029. Consider uploading reports for the commit 4bd8029 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #686 +/- ## ========================================== - Coverage 92.11% 92.04% -0.07% ========================================== Files 9 9 Lines 482 503 +21 Branches 102 108 +6 ========================================== + Hits 444 463 +19 - Misses 20 21 +1 - Partials 18 19 +1 ``` | [Files Changed](https://app.codecov.io/gh/redhatcloudx/transformer/pull/686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx) | Coverage Δ | | |---|---|---| | [src/cloudimagedirectory/transformer.py](https://app.codecov.io/gh/redhatcloudx/transformer/pull/686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx#diff-c3JjL2Nsb3VkaW1hZ2VkaXJlY3RvcnkvdHJhbnNmb3JtZXIucHk=) | `77.77% <ø> (ø)` | | | [src/cloudimagedirectory/transform/transform.py](https://app.codecov.io/gh/redhatcloudx/transformer/pull/686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx#diff-c3JjL2Nsb3VkaW1hZ2VkaXJlY3RvcnkvdHJhbnNmb3JtL3RyYW5zZm9ybS5weQ==) | `90.97% <90.47%> (-0.04%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

miyunari commented 1 year ago

I'd like to see us find a way to interrogate these transformers with more specific tests rather than examining the full entire output, but this looks good enough to go for now. I can help with test coverage and mypy issues.

Yes, you are absolutely right with this, I think we all see it that way. Therefore I created an issue a while ago, but currently we needed to prioritize and decided to add them later and focus on the second API version this quarter :/ At the moment the code changes so fast, that we would need to adjust them multiple times, that was another reason, we thought it would be better to wait until the big changes are made :/ But we should definitely add those in the long run!