redhatcloudx / transformer

Find RHEL images in public clouds
Apache License 2.0
6 stars 3 forks source link

V2 list version by provider #592 #687

Closed miyunari closed 1 year ago

miyunari commented 1 year ago

closes #592

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 92.00% and project coverage change: -0.01% :warning:

Comparison is base (e274b30) 92.04% compared to head (0ac79b4) 92.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #687 +/- ## ========================================== - Coverage 92.04% 92.04% -0.01% ========================================== Files 9 9 Lines 503 528 +25 Branches 108 116 +8 ========================================== + Hits 463 486 +23 - Misses 21 22 +1 - Partials 19 20 +1 ``` | [Files Changed](https://app.codecov.io/gh/redhatcloudx/transformer/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx) | Coverage Δ | | |---|---|---| | [src/cloudimagedirectory/transformer.py](https://app.codecov.io/gh/redhatcloudx/transformer/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx#diff-c3JjL2Nsb3VkaW1hZ2VkaXJlY3RvcnkvdHJhbnNmb3JtZXIucHk=) | `77.77% <ø> (ø)` | | | [src/cloudimagedirectory/transform/transform.py](https://app.codecov.io/gh/redhatcloudx/transformer/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx#diff-c3JjL2Nsb3VkaW1hZ2VkaXJlY3RvcnkvdHJhbnNmb3JtL3RyYW5zZm9ybS5weQ==) | `91.05% <92.00%> (+0.08%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

miyunari commented 1 year ago

Yes, we already have the issues for adding more failing test cases and add unit tests :) I hope we can maybe tackle this right after the new API version :) https://github.com/redhatcloudx/transformer/issues/421 https://github.com/redhatcloudx/transformer/issues/424