redhatcloudx / transformer

Find RHEL images in public clouds
Apache License 2.0
6 stars 3 forks source link

V2ListRegionByVersion: Try simplifying #694

Closed major closed 1 year ago

major commented 1 year ago

Remove some loops and build out a DataEntry-like structure from the start. Then convert it to data entries.

The complexity came down enough that we can remove the ruff ignore line.

Update the test to check all results and add an extra google entry for 9 so we can verify it comes back with a count of 2.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15% :tada:

Comparison is base (53bce11) 91.63% compared to head (ccded14) 91.79%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #694 +/- ## ========================================== + Coverage 91.63% 91.79% +0.15% ========================================== Files 9 9 Lines 550 536 -14 Branches 118 113 -5 ========================================== - Hits 504 492 -12 + Misses 24 23 -1 + Partials 22 21 -1 ``` | [Files Changed](https://app.codecov.io/gh/redhatcloudx/transformer/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx) | Coverage Δ | | |---|---|---| | [src/cloudimagedirectory/transform/transform.py](https://app.codecov.io/gh/redhatcloudx/transformer/pull/694?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx#diff-c3JjL2Nsb3VkaW1hZ2VkaXJlY3RvcnkvdHJhbnNmb3JtL3RyYW5zZm9ybS5weQ==) | `90.62% <100.00%> (+0.20%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.