redhatcloudx / transformer

Find RHEL images in public clouds
Apache License 2.0
6 stars 3 forks source link

Instrument the transformer using the opentelemetry-sdk #727

Closed miyunari closed 1 year ago

miyunari commented 1 year ago

This PR instruments:

While I have still an open question how to call the counter add method when data gets filtered using lambda.

As a next step, we have to add a otel exporter to store and visualize the data.

closes #728

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.38% :tada:

Comparison is base (326229b) 92.85% compared to head (019d968) 93.23%. Report is 1 commits behind head on main.

:exclamation: Current head 019d968 differs from pull request most recent head d5e1196. Consider uploading reports for the commit d5e1196 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #727 +/- ## ========================================== + Coverage 92.85% 93.23% +0.38% ========================================== Files 9 9 Lines 532 562 +30 Branches 110 112 +2 ========================================== + Hits 494 524 +30 Misses 21 21 Partials 17 17 ``` | [Files Changed](https://app.codecov.io/gh/redhatcloudx/transformer/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx) | Coverage Δ | | |---|---|---| | [src/cloudimagedirectory/transformer.py](https://app.codecov.io/gh/redhatcloudx/transformer/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx#diff-c3JjL2Nsb3VkaW1hZ2VkaXJlY3RvcnkvdHJhbnNmb3JtZXIucHk=) | `77.77% <ø> (ø)` | | | [src/cloudimagedirectory/filter/filter.py](https://app.codecov.io/gh/redhatcloudx/transformer/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx#diff-c3JjL2Nsb3VkaW1hZ2VkaXJlY3RvcnkvZmlsdGVyL2ZpbHRlci5weQ==) | `100.00% <100.00%> (ø)` | | | [src/cloudimagedirectory/transform/transform.py](https://app.codecov.io/gh/redhatcloudx/transformer/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhatcloudx#diff-c3JjL2Nsb3VkaW1hZ2VkaXJlY3RvcnkvdHJhbnNmb3JtL3RyYW5zZm9ybS5weQ==) | `91.97% <100.00%> (+0.20%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.