search

redhatdemocentral / ocp-install-demo

OpenShift Container Platform installed in fully automated and repeatable fashion on your laptop. Get started with your containerized development with a private PaaS installed in just minutes.
82 stars 60 forks source link

Updated docker version check #22

Closed srinivasa-vasu closed 7 years ago

srinivasa-vasu commented 7 years ago

Checking docker by major and minor version independently fails. Lets say 17.03 is the current version, major version 17 is > 1, but the minor version 03 !> 10 and hence it fails though 17.10 is clearly > 1.10

eschabell commented 7 years ago

First, thanks for the PR, appreciate the help, but....

We don't support Docker versions 17.x... oc client fails using this version. I can't apply this to the project until oc client released that can work with these versions.

Currently only support from 1.10 downwards and a special alpha version that can be built based on a patch submitted to OpenShift client team. This was pushed in this commit:

https://github.com/redhatdemocentral/ocp-install-demo/commit/5e22c5b1b671afa7d99384c129b7f77c77dfdf81

Also see the oc-builder.sh which was added shortly there after.