redhobor / transmisson-remote-gui

Automatically exported from code.google.com/p/transmisson-remote-gui
GNU General Public License v2.0
0 stars 0 forks source link

Sanity for ratio to use uploaded/(max(downloaded,actual size)) #777

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Have a torrent that you (for unknown reasons) you have downloaded a small 
amount. I have 16 torrents that show <1KB of download -- as small as 52 bytes, 
to as large as 876 bytes.

2. Torrents are 'normal' for large media -- smallest 4G, largest 54G.. 
3. Display ratios:
 Downld    Upload        Ratio
    51B,  196.8GB, => 4119138144 ratio
   245B,  110.0GB, => 479659125 ratio
  3235B,   66.2GB, => 21914184 ratio
   573B,    1.4GB, => 2578946 ratio
  2304B,  138.1GB, => 64233624 ratio
   235B,  100.8GB, => 458652709 ratio
   296B,  202.8GB, => 731848555 ratio
   901B,  113.9GB, => 135454151 ratio
   276B,  146.0GB, => 565900866 ratio
   133B,  149.4GB, => 1202703327 ratio
   133B,   42.7GB, => 343825027 ratio
  1085B,  189.2GB, => 186795553 ratio
   122B,   71.5GB, => 623295230 ratio
  4515B,  138.8GB, => 32938373 ratio
    81B,   51.8GB, => 677758343 ratio
136704B,  527.9GB, => 4138297 ratio
   368B,   63.9GB, => 185787967 ratio
   337B,   63.7GB, => 201948384 ratio
   102B,  306.1GB, => 3203425269 ratio
--------------
What is the expected output? What do you see instead?

Would rather see ratio using the torrent size if the amount loaded is < torrent 
size, (not just zero).  Those are pretty ridiculous ratios... ;-)

I have no idea how a few bytes 'leaked down',
but, it happens frequently enough, that I suspect I'm not the only one.

Thanks for a great product!

What version of the product are you using? 

5.01

On what operating system?
win7x64

Please provide any additional information below.

Original issue reported on code.google.com by astara.a...@gmail.com on 15 Apr 2014 at 3:52

GoogleCodeExporter commented 9 years ago
here is patch and transgui.exe for what you want. but you might want use 
'totalSize' instead of 'sizeWhenDone', depends on how you think about it.

Also now we don't get a running ratio of  uploadING / downloadING   any more ? 
hhhmmmmm ??

It might be better to have the daemon patched in libtransmission to handle some 
things.

see http://code.google.com/p/transmisson-remote-gui/issues/detail?id=774#c1 for 
notes on using my compiled transgui.exe

Original comment by s...@yourfreemail.info on 15 Apr 2014 at 8:15

Attachments:

GoogleCodeExporter commented 9 years ago
When I try running the .exe, I get a json element 'downloaded ever' not found...

Interesting, this a graph panel?

Original comment by astara.a...@gmail.com on 16 Apr 2014 at 4:59

GoogleCodeExporter commented 9 years ago
I fix the json error I hope and also decided  to create an additional column. 
Now there is a new "Seed Ratio" column and renamed the old ratio column to "U-D 
Ratio" (Upload-to-Download Ratio)

diff from my working copy should be able to be reworked to v5.0.1

let me know if json error is gone for you.

Original comment by s...@yourfreemail.info on 16 Apr 2014 at 6:07

Attachments:

GoogleCodeExporter commented 9 years ago
for the OLDer test ratio.patch and transgui.exe the columns "Download", 
"Uploaded" and "Size to download" must be enabled **before** running it. I 
think I like the new one that I just posted better, but the old way could be 
fixed...  

The new one should not have the bugs ;)

Original comment by s...@yourfreemail.info on 16 Apr 2014 at 6:42

GoogleCodeExporter commented 9 years ago
It works!... 

What I dunno how useful, really the U/D amount is, .. and maybe even
less so the U'ing' and D'ing'...  I'm not sure how or why it would be used?

Why would I want to use 'total size' vs. size when done?
Seems like ... size-w-d is size of what you download (i.e. if I don't download 
some parts).  I think my reasoning in some ways -- is that the ratio to the 
'world', 
is uploaded / size of what you have downloaded ... i.e.unless you make it 
yourself, it came from somewhere, so a realistic number would be, at least the 
size of what you have downloaded (though not total size, cuz you may never 
download some parts).

If I understand those terms correctly, that is...

Original comment by astara.a...@gmail.com on 17 Apr 2014 at 12:16

GoogleCodeExporter commented 9 years ago

My latest patch above adds an additional column which displays the calculated 
"Seed Ratio" =
FTorrents[idxSdRatio, row]:=t.Floats['uploadedEver']/t.Floats['sizeWhenDone']

and leaves the original column of U/D "Ratio" (directly provided by the daemon) 
=
t.Floats['uploadRatio'] 

The U/D amount (uploadedEver / downloadedEver) only makes sense to me for a 
completed download started from zero and NOT for an initial seed. For an 
initial seed the ratio always is
infinity (uploaded / 0), since we've downloaded absolutely nothing. Or for 
leaked bytes downloaded to an initial seed, a very high number, but still 
useless meaning for U/D.

I think of the U/D amount WHILE a torrent is downloading, as a thinking idea 
idea of the ever-changing real time average ratio of the
upload-speed / download-speed derived from
uploadedEver / downloadedEver and not from the actual daemon stats speed 
measurements. Reality of this is - acquired amounts of downloaded bytes 
physically written to the storage media do change (and is dictated by the 
actual "rateDownload") while uploaded bytes do not change anything physically 
to the storage media torrent file(s) as do downloaded bytes.

Another way put, I think of the U/D ratio while downloading as "probable seed 
ratio once download completes (based on the current amounts uploaded and 
downloaded)".

I see no use whatsoever in ever using 'totalSize' in the calculations. I just 
thought maybe someone else might have a different idea. To include files I'm 
not downloading in the calculations seems wrong to me. 'sizeWhenDone' depicts 
what I plan on downloading or what files I choose to seed and is the only way 
that makes sense to me.

"Sanity ratio" is a good idea for multiple reasons, not just leaked bytes. 
Thanks astara.a for inspiring me to create one possible way to fix it. I hope 
that your idea makes it into the next release.

Original comment by s...@yourfreemail.info on 18 Apr 2014 at 4:06

GoogleCodeExporter commented 9 years ago
edit: for (uploaded / 0) I mean that 'downloadedEver' approaches zero like 1 
byte for a 50 gig download but only in case of actual zero does libtransmission 
use the "haveValid" value... and a sane ratio

Original comment by s...@yourfreemail.info on 19 Apr 2014 at 12:50