Does not generate https links

redhog / ep_fileupload

File upload plugin for Etherpad Lite

http://redhog.org/ep_fileupload

7 stars 13 forks source link

Does not generate https links #12

Open crapp opened 10 years ago

crapp commented 10 years ago

From controllers/fileUpload.js:

// FIXME: Calculate URL for real, with path prefix and with https handling
res.send(eejs.require("ep_fileupload/templates/fileUploaded.ejs", {upload: 'http://' + req.headers.host + "/up/" + name}, module));

So you already know of the problem :)

I fixed it temporarily by replacing http:// with https:// as my etherpad lite installation is only available via https.

mweinelt commented 10 years ago

Also I'd prefer if there would relative URLs instead of absolute ones.

Writing the full URL to the pad text means

breaks when migrating
breaks, when server is available for different networks under different hostnames (fqdn vs local vs vpn)

Therefore it would be cool if you could move this to some kind of bbcode-like img-Tag instead of simply searching for http-URLS with graphic files at the end.