redhog / ep_fileupload

File upload plugin for Etherpad Lite
http://redhog.org/ep_fileupload
7 stars 13 forks source link

etherpad lite server crash on abort fileupload #22

Open clayu opened 8 years ago

clayu commented 8 years ago

When uploading a large file, if you leave the page during the upload incoming_form.js emits an error. The error propagates up and crashes the server. See below

Error: Request aborted at IncomingMessage. (/ep_fileupload/node_modules/formidable/lib/incoming_form.js:120:19) at IncomingMessage.emit (events.js:92:17) at abortIncoming (http.js:1916:11) at CleartextStream.serverSocketCloseListener (http.js:1928:5) at CleartextStream.emit (events.js:117:20) at tls.js:694:10 at process._tickDomainCallback (node.js:486:13)

JohnMcLear commented 8 years ago

try wrap it in a try catch or put in some error handling for the function please :)