search

redhotpenguin / perl-Archive-Zip

Archive::Zip as seen at https://metacpan.org/pod/Archive::Zip
Other
15 stars 44 forks source link

Extend GitHub test actions on A::Z to also run parallel, shuffled tests #79

Closed farblos closed 4 years ago

farblos commented 4 years ago

@pmqs: In .travis.yml I have added the following some time ago:

   # run tests twice.  First in serial, non-shuffled order to get
   # readable output, then in parallel and shuffled.  Leave
   # verbose mode off for both runs since in automated test
   # environments the tests are verbose already by default.
   - prove -lr $(test-dirs) && prove -lrs -j$((SYSTEM_CORES + 1)) $(test-dirs)

Since parallel/shuffled mode has the potential to reveal more problems, this seems to be a good thing.

Do you think anything like that would be also possible with your GitHub actions?

pmqs commented 4 years ago

@farblos that is certainly possible if you think it would help.

According to this page all GitHub runners have 2 cores. Don't see an environment variable available for it in the docs, so can probably hard-wire it to use this

prove -lrs -j2 $(test-dirs)
farblos commented 4 years ago

@farblos that is certainly possible if you think it would help.

The 1.68 CPAN test runs have revealled two nice race conditions when executed in parallel, so there is always a chance of finding something. The problem with these is, of course, that actually someone has to follow up on seemingly exceptional failures...

so can probably hard-wire it to use this prove -lrs -j2 $(test-dirs)

Agreed. Thanks!

pmqs commented 4 years ago

See https://github.com/redhotpenguin/perl-Archive-Zip/pull/80 for the update

farblos commented 4 years ago

Thanks again!