search

redhotpenguin / perl-Archive-Zip

Archive::Zip as seen at https://metacpan.org/pod/Archive::Zip
Other
15 stars 44 forks source link

Archive-Zip does not pack symlinks correctly #81

Open ericd123 opened 4 years ago

ericd123 commented 4 years ago

repro.txt

See attached perl script to reproduce the problem.

Basically when an archive is being created, _writeData is calling symlink - this should only be done when extracting an archive. From what I see, the call to symlink should only be done from extractToFileHandle and not done in the shared _writeData method as _writeData is used for both extracting from (extractToFileHandle) and writing to (_writeToFileHandle) zip archives.

jkahrman commented 4 years ago

Archive-Zip.symlinks.patch.txt

theory commented 3 years ago

Deleted comment above, thought I was somewhere else 🤦🏻

redhotpenguin commented 3 years ago

I think many of us were wishing we were somewhere else during this pandemic. No worries!

On Tue, May 11, 2021, 1:45 PM David E. Wheeler @.***> wrote:

Deleted comment above, thought I was somewhere else 🤦🏻

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/redhotpenguin/perl-Archive-Zip/issues/81#issuecomment-839151072, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXRZIDCQ6R77MRAMMIEXTTNGJONANCNFSM4NTZSQYA .