search

redimp / otterwiki

A minimalistic wiki powered by python, markdown and git.
https://otterwiki.com
MIT License
202 stars 22 forks source link

Update layout.html so that search bar toggles are possible with CTRL + / #94

Closed Jocho-Smith closed 4 months ago

Jocho-Smith commented 4 months ago

I tested it now and it works like this. I'm not sure though if that location is the 'best' for such a functionality.

See https://github.com/redimp/otterwiki/issues/93

redimp commented 4 months ago

Thanks for this PR.

I'm not convinced that Ctrl-/ is the best choice for a search shortcut, though.

Not tested yet, but I'm not sure that this is a hotkey that works well in all environments.

Github supports / which feels like the natural choice .. Have to research (and test) why Ctrl-K and Cmd-K (on MacOS) are such a common choice for web apps.

Jocho-Smith commented 4 months ago

I see.

In my firefox browser ctrl-k toggels the url bar of the browser itself with @Google before it. I can imagine that this conflicts, the functionality with other browsers as well.

I would love to help/support further, if I can.

redimp commented 4 months ago

Working on a solution, will update in #93