redimp / otterwiki

A minimalistic wiki powered by python, markdown and git.
https://otterwiki.com
MIT License
202 stars 22 forks source link

Proof of concept for reverse-proxy auth #95

Closed weaversam8 closed 3 months ago

weaversam8 commented 4 months ago

CC @redimp. I didn't make the headers configurable for now, and I'm sure this is a bit hacky, so interested to hear what you think.

redimp commented 4 months ago

That looks very good. I don't have time to set up a test environment until the weekend. I will then test and merge or let you know if I run into problems.

Awesome work @weaversam8 !

redimp commented 4 months ago

First test went fine!

I have added the commits in the branch feature/proxy-header-auth. This branch includes a minimal test example. A more serious example would be useful.

Some thoughts:

weaversam8 commented 3 months ago

I just pulled and tested these changes. Fixed one tiny bug in 7b3098c but otherwise this looks great! I think this example is plenty sufficient to show how this is used, thanks for putting that together!

I rebased my branch off of main and pushed, so this PR should be good to merge (since it now contains your changes.)

redimp commented 3 months ago

Merged. Thank you for the work.

Will do a new release including this feature within the next two days.