search

redis-developer / introducing-the-geosearch-command

Demo application using a Bulma / Leaflet JS / JavaScript front end and Python / Flask backend to demonstrate the GEOSEARCH command added in Redis 6.2.
https://developer.redis.com/
MIT License
14 stars 13 forks source link

Fix use of deprecated `hmset` command when running the data loader. #19

Closed simonprickett closed 1 year ago

simonprickett commented 1 year ago

The data loader for this project uses the deprecated hmset command. Fix this to use hset appropriately and remove deprecated hmset:

python load_stations.py
/Users/simonprickett/source/github/introducing-the-geosearch-command/load_stations.py:39: DeprecationWarning: Pipeline.hmset() is deprecated. Use Pipeline.hset() instead.
  pipeline.hmset(station_key, station_data)
Loaded 52 stations.

Use the dict mapping with hset: https://redis-py.readthedocs.io/en/stable/commands.html?highlight=hset#redis.commands.core.CoreCommands.hset

This is part of our participation in Hacktoberfest 2022. Learn how to complete this issue here: https://redis.io/community/hacktoberfest/

Need help or want to talk to us? Join us on Discord where we have a dedicated Hacktoberfest channel: https://discord.gg/ueQwKUh5Z3

If you're interested in taking this issue on, please mention @simonprickett and @SuzeShardlow in the comments and ask to be assigned.

RajputUsman commented 1 year ago

Could you assign this to me? @simonprickett @SuzeShardlow

SuzeShardlow commented 1 year ago

This issue is available and up for grabs. If you would like to work on it, please reply and tag me and @simonprickett :)

meirdev commented 1 year ago

Can you assign it to me? @SuzeShardlow @simonprickett

SuzeShardlow commented 1 year ago

Hi @meirdev, I've assigned this to you, looking forward to seeing your PR in the next couple of days. Have fun and please check out our guidelines:

https://redis.io/community/hacktoberfest/

meirdev commented 1 year ago

23 - done.

SuzeShardlow commented 1 year ago

Closed by #23.