redis-rb / redis-client

Simple low level client for Redis 6+
MIT License
124 stars 60 forks source link

Raise a useful error when reconnecting with a circuit breaker #145

Closed ccutrer closed 11 months ago

ccutrer commented 11 months ago

If you have reconnects enabled, and a circuit breaker configured, it's useful to raise the actual underlying error when we actually attempted the connection instead of simply the circuit breaker error. The circuit breaker error will still be raised if no attempts were tried.

byroot commented 11 months ago

Some minor code style things, but otherwise LGTM.

ccutrer commented 11 months ago

Ping @byroot

byroot commented 11 months ago

Rubocop is angry again, but I'll fix it on master

ccutrer commented 11 months ago

Rubocop is angry again, but I'll fix it on master

Thanks, I appreciate it :).