jgmontoya
commented
8 months ago @byroot I'm having issues getting the tests to work within the test framework 😅
For some reason Ractor.new fails and I'm not understanding why. I'd appreciate a hand with this if you have any idea of what could be going on.
I tried creating a simple test: ractor_test.rb
# frozen_string_literal: true
require "test_helper"
class RactorTest < Minitest::Test
include ClientTestHelper
def test_set_within_ractor
Ractor.new do
within_ractor_redis = new_client
within_ractor_redis.call("SET", "foo", "bar")
end
out_of_ractor_redis = new_client
assert_equal("bar", out_of_ractor_redis.call("GET", "foo"))
end
def test_get_within_ractor
out_of_ractor_redis = new_client
out_of_ractor_redis.call("SET", "foo", "bar")
ractor = Ractor.new do
within_ractor_redis = new_client
within_ractor_redis.call("GET", "foo")
end
assert_equal("bar", ractor.take)
end
endI did however manage to get it to work "manually" (i.e. outside of the testing framework) in a separate script (had to rename some imports from require to require_relative to make sure it was taking the local project):
# frozen_string_literal: true
require_relative 'lib/redis_client'
def new_client
RedisClient.new(host: 'localhost', port: 53285, timeout: 0.1) # I had a redis instance running on that port
end
def test_get_within_ractor
out_of_ractor_redis = new_client
out_of_ractor_redis.call('SET', 'foo', 'bar')
ractor = Ractor.new do
within_ractor_redis = new_client
within_ractor_redis.call('GET', 'foo')
end
p ractor.take == 'bar' # => true
end
def test_set_within_ractor
Ractor.new do
within_ractor_redis = new_client
within_ractor_redis.call('SET', 'foo', 'bar')
end
out_of_ractor_redis = new_client
p out_of_ractor_redis.call('GET', 'foo') == 'bar' # => true
end
def test_get_set_within_ractor
ractor = Ractor.new do
within_ractor_redis = new_client
within_ractor_redis.call('SET', 'foo', 'bar')
within_ractor_redis.call('GET', 'foo')
end
p ractor.take == 'bar' # => true
end
def test_multiple_ractors
ractor1 = Ractor.new do
within_ractor_redis = new_client
within_ractor_redis.call('SET', 'foo', 'bar')
within_ractor_redis.call('GET', 'foo')
end
p ractor1.take == 'bar' # => true
ractor2 = Ractor.new do
within_ractor_redis = new_client
within_ractor_redis.call('GET', 'foo')
end
p ractor2.take == 'bar' # => true
end
test_get_within_ractor
test_set_within_ractor
test_get_set_within_ractor
test_multiple_ractorsAny ideas on how we could take that "manual testing" unto minitest?
byroot
casperisfine
Addresses https://github.com/redis-rb/redis-client/issues/162 while keeping the ability to accept subclasses of accepted types as command arguments (https://github.com/redis-rb/redis-client/commit/9fb715fb1a3e1caf91d9b7fa921532085d47c707).
The tradeoff made is losing the cache on the subclass. I think this is reasonable as the length of DUMP_TYPES.keys is fixed to 4.