redis-rb / redis-client

Simple low level client for Redis 6+
MIT License
124 stars 60 forks source link

Remove unused files from the gem package #210

Closed orien closed 2 months ago

orien commented 2 months ago

There are a bunch of files in the gem package that aren't useful for downstream projects. Security scans can get caught up with the contents of the Gemfile.lock even though it is given no heed.

Let's remove these files:

  CHANGELOG.md
- Gemfile
- Gemfile.lock
  LICENSE.md
  README.md
- Rakefile
  lib/redis-client.rb
  lib/redis_client.rb
  lib/redis_client/circuit_breaker.rb
  lib/redis_client/command_builder.rb
  lib/redis_client/config.rb
  lib/redis_client/connection_mixin.rb
  lib/redis_client/decorator.rb
  lib/redis_client/middlewares.rb
  lib/redis_client/pid_cache.rb
  lib/redis_client/pooled.rb
  lib/redis_client/ruby_connection.rb
  lib/redis_client/ruby_connection/buffered_io.rb
  lib/redis_client/ruby_connection/resp3.rb
  lib/redis_client/sentinel_config.rb
  lib/redis_client/url_config.rb
  lib/redis_client/version.rb
- redis-client.gemspec
casperisfine commented 2 months ago

Thanks, you probably want to do something similar to https://github.com/redis-rb/redis-client/blob/50b874fdc7f958642e8f1cc75538c616ae14afe6/hiredis-client/hiredis-client.gemspec ? Just for consistency's sake?

orien commented 2 months ago

Updated in 90a61a3.

byroot commented 2 months ago

Grumble. This breaks the JRuby CI. It does ring a bell, I think JRuby doesn't have a proper $PATH for some reason.

orien commented 2 months ago

Ok, let's try this one.