search

redis-rb / redis-client

Simple low level client for Redis 6+
MIT License
125 stars 60 forks source link

Ruby 2.7 issue #49

Closed mperham closed 2 years ago

mperham commented 2 years ago 
/Users/mperham/.gem/ruby/2.7.5/gems/redis-client-0.8.0/lib/redis_client/decorator.rb:26: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/Users/mperham/.gem/ruby/2.7.5/gems/redis-client-0.8.0/lib/redis_client.rb:254: warning: The called method `blocking_call' is defined here
casperisfine commented 2 years ago

I tried to repro with:

require 'redis_client'
require 'redis_client/decorator'
$VERBOSE = true
Warning[:deprecated] = true

p RUBY_VERSION

decorator = RedisClient::Decorator.create(Module.new)
client = decorator.new(RedisClient.new)

p client.blocking_call(1, 'set', 'foo', 'bar', ex: 12)

But I don't see any warning.

That's the best I could do with the provided information. So closing as non actionable. I'll re-open if you can provide a reproduction.

mperham commented 2 years ago

Apologies, I misunderstood the output since it didn't show any of my code but the issue was mine.

byroot commented 2 years ago

Yeah, that's a frequent issue with 2.7 keyword args and delegation.