search

redis-store / redis-actionpack

Redis stores for ActionPack
http://redis-store.org/redis-actionpack
MIT License
76 stars 44 forks source link

Bump max version constraint on actionpack #25

Closed afrojun closed 5 years ago

afrojun commented 5 years ago

This change allows this gem to work with Rails 6.

Bundler output below:

...
    rails (~> 6) was resolved to 6.0.0, which depends on
      activesupport (= 6.0.0)

    redis-rails (~> 5.0.2) was resolved to 5.0.2, which depends on
      redis-activesupport (>= 5.0, < 6) was resolved to 5.0.7, which depends on
        activesupport (>= 3, < 6)
...
tubbo commented 5 years ago

@marceloboeira those failures are happening on master as well, I don't think it's a result of this change in version. I'm still trying to figure out the builds on those older Ruby versions but haven't had the time to dive in...

marceloboeira commented 5 years ago

@tubbo awesome, thanks for the info. Let's wait for the update on the version specification ...

afrojun commented 5 years ago

Thanks for taking a look! I've updated the constraint to < 7 as requested.

ojab commented 5 years ago

Can I haz a release with this PR included pretty please? And the same for redis-store/redis-activesupport after https://github.com/redis-store/redis-activesupport/pull/121 is merged.

tubbo commented 5 years ago

@ojab this has been released as redis-actionpack v5.1.0