search

redis-store / redis-actionpack

Redis stores for ActionPack
http://redis-store.org/redis-actionpack
MIT License
76 stars 44 forks source link

Rails 5 support #8

Closed marcroberts closed 8 years ago

saks commented 8 years ago

+1

marcroberts commented 8 years ago

I've rebased my fork agains the updated master, and left ruby 1.9 in there still.

I'll add multiple test gem files to test rails 4 and 5 explicitly

tubbo commented 8 years ago

hey @marcroberts, looks pretty good but we have a failing build...could you resolve those test failures? https://travis-ci.org/redis-store/redis-actionpack/builds/101072902

marcroberts commented 8 years ago

I'm working on fixing the Rails 5 failure, these recent commits should fix most/all of the other failures/errors.

marcroberts commented 8 years ago

That should sort it out

tubbo commented 8 years ago

@marcroberts thank you so much! unfortunately, travis seems to be stopped up on the jruby and rubinius tests, so I restarted the build to make sure they all pass. I'm sure they will given all of the various MRI versions passed, though...

marcroberts commented 8 years ago

Looking at travis, the Rubinius test did actually pass, and the jruby test won't pass for rails5 as Rack 2.x requires a more recent version of Ruby so that will have to be excluded from the matrix

tubbo commented 8 years ago

laaaame, thanks for excluding that :) we'll figure out what to do about jruby's tests later as we still have some time before the rails 5 RCs start getting released. as soon as these checks pass I'll merge.

tubbo commented 8 years ago

@marcroberts what's up with the rubinius & rails 4.1/4.0 tests?

ujh commented 8 years ago

According to the Travis documentation rbx-19mode isn't supported anymore.

Note that the syntax of rbx-19mode isn’t supported anymore.

I guess that's where the failures are coming from.

tubbo commented 8 years ago

Since everything else is passing I'll take responsibility for editing .travis.yml to disable rbx-19mode going forward.

tubbo commented 8 years ago

Thanks for being so patient @marcroberts, and thank you again for providing these necessary updates so we can make sure that the redis-store gems are ready for Rails 5.