search

redis / NRedisStack

Redis Stack .Net client
MIT License
233 stars 38 forks source link

Update CLIENT-SETINFO to support suffixes #185

Closed chayim closed 1 year ago

chayim commented 1 year ago

CLIENT SETINFO should be extended to support community members inserting their own suffixes, for Redis usage.

  1. Clients should by default set-lib during connect with their name and version.
  2. Clients should allow users to not send this
  3. We should allow a user do send a suffix to the LIB-NAME portion - this allows us to learn about how things are used.
  4. Our clients continue to send their version upstream for LIB-VER

Strings should have the client name, and an optional suffix. They should be formatted ClientName(). For example:

  1. If you're NRedisStack - LIB-NAME: NRedisStack(StackExchange.Redis-v2.6.8;.NET-6.2.18) LIB-VERSION: 0.9.1
  2. If you're a project using NRedisStack (say SemtanticKernel): LIB-NAME (NRedisStack(SemanticKernel-v0.1.7;.NET-6.2.18) LIB-VERSION: 0.9.1

Considerations:

  1. Users should not send brackets, or braces, and we should error accordingly.
  2. We should replace spaces a user sends with hyphens
shacharPash commented 1 year ago

Fixed in #180