search

redis / go-redis

Redis Go client
https://redis.uptrace.dev
BSD 2-Clause "Simplified" License
20.06k stars 2.37k forks source link

RediSearch Support #2801

Closed ofekshenawa closed 4 months ago

jiangtao244 commented 7 months ago

how is this mr going？

quenbyako commented 3 months ago

@ofekshenawa @vladvildanov @chayim @jiangtao244 hi guys, sorry for interrupting, we stucked with using RediSearch in golang, under RESP3 protocol, especially with FT.AGGREGATE and FT.SEARCH commands:

I found that RESP3 testing code was commented for some reason, so in production it doesn't work at all (incorrect response parsing) β€” any luck with supporting third version of protocol?

If there is no pull request which fixes that problem, I created a fork with completed implementation of supporting "new" version of response, should I create a pull request for that?

vladvildanov commented 3 months ago

@quenbyako Thank you for reaching us out! Sorry for the bad experience, but we had to rollback our latest release that brings a support for RediSearch, so this functionality is considered non-finished. We're planning to release it very soon, but on the first stage it will be RESP2 only, RESP3 support will be a part of the release after this.

Stay tuned for update in near future!

quenbyako commented 3 months ago

@vladvildanov Glad that you responded so quick, thank you πŸ˜ŠπŸ™

Regarding to features rollback: Was this lack of compatibility for RESP3 documented somewhere? Cause I spent yesterday nearly 5 hours to undestand what's happened, and it was hell, there is completely no info about this one...

I implemented quick and dirty support for ft.aggregate command, please, take a look if you have some time, for our project redisearch is really important part, and I really want to collaborate with you guys on that feature addition, if that's possible πŸ€—

vladvildanov commented 3 months ago

@quenbyako The RESP3 will be partially compatible in near future and will be explained in the statement we prepare for community. We apologise that it forced you to dig into it, it was totally not planned to release it "that" way. We promise to properly communicate it with you πŸ‘Œ

vladvildanov commented 3 months ago

@quenbyako Join our discord community, there's a channel dedicated to go-redis as well https://discord.gg/zhvcaDMc

quenbyako commented 3 weeks ago

Hi @vladvildanov any update about this?

vladvildanov commented 2 weeks ago

@quenbyako Hey! Sorry for the delay, we're about to release Search support along with JSON in RESP2, will be included into next release

sainad2222 commented 1 week ago

Hi @vladvildanov, Is there any ongoing issue that I can track for progress? Not able to join discord invite that was shared above too

vladvildanov commented 1 week ago

@sainad2222 Hey! Search support has been released and it's a part of 9.7.0