Open Aden-Q opened 11 months ago
@chayim why this was a bug? I would expect a breaking change only happens at major version updates.
@szuecs Honest mistake frankly. Happens sometimes.
@ofekshenawa IMHO we need to revert accordingly and release a 9.4.0 due to this. I would minor the bugfix
If we feel this breaking matters - we can stack it up for future v10.
Absolutely, I agree. We plan to release version 9.4.0 this Sunday, which will include the necessary fix.
Thanks!
Expected Behavior
According to the redis doc, zset members should always be strings. We want zset members to be returned as strings so that we don't have to do type assertion explicitly.
Current Behavior
zset member is returned as an interface: https://github.com/redis/go-redis/blob/21bd40a47e56e61c0598ea1bdf8e02e67d1aa651/sortedset_commands.go#L730
Possible Solution
Define the Z struct's member field as a string type: https://github.com/redis/go-redis/blob/21bd40a47e56e61c0598ea1bdf8e02e67d1aa651/sortedset_commands.go#L728-L731
Steps to Reproduce
Context (Environment)
Detailed Description
Possible Implementation