search

redis / go-redis

Redis Go client
https://redis.uptrace.dev
BSD 2-Clause "Simplified" License
19.89k stars 2.34k forks source link

Change Z member type to string #2818

Closed ofekshenawa closed 9 months ago

ofekshenawa commented 9 months ago

Closes #2817

jarno-rootz commented 8 months ago

You don't do semantic versioning in go-redis? This is a breaking change.

AlexanderYastrebov commented 8 months ago

This change breaks our code https://github.com/zalando/skipper/pull/2806

# github.com/zalando/skipper/net
net/redisclient.go:404:47: cannot use val (variable of type int64) as string value in struct literal

as we used int64

knadh commented 8 months ago

I would expect a breaking change only happens at major version updates.

This change seems to be a mistake. Going by the spec, all values in Redis are "strings", including Set(), which currently takes an interface{}. Changing the type in ZMember to string doesn't make any sense.

Also, this is a semver breaking change pushed in a minor version that just broke our codebase.