Revert #2818 due to it be a breaking change

redis / go-redis

Redis Go client

https://redis.uptrace.dev

BSD 2-Clause "Simplified" License

19.65k stars 2.32k forks source link

Revert #2818 due to it be a breaking change #2861

Closed ofekshenawa closed 6 months ago

ofekshenawa commented 6 months ago

Revert #2818 due to a breaking change

sjpotter commented 6 months ago

commit message should make clear why this change is occurring.

sjpotter commented 6 months ago

Approved, but I'd rename the PR to "Revert #XYZ due to it be a breaking change". As that's the point of the PR, inteface vs string is somewhat irrelevant to that point.