search

redis / go-redis

Redis Go client
https://redis.uptrace.dev
BSD 2-Clause "Simplified" License
19.65k stars 2.32k forks source link

Speed up connections by sending SetInfo via a pipeline #2880

Closed ofekshenawa closed 5 months ago

chayim commented 5 months ago

part of #2850

git-hulk commented 5 months ago

@ofekshenawa @chayim This change will break users using Redis version < 7.2 which doesn't support the CLIENT SETINFO command. The previous version works well since the command error was ignored, bringing them into the pipeline will throw an error.

BTW, I think it'd be better to set DisableIndentity to true by default, for the sake of 7.2 is too new to most users. I will be happy to send a PR to resolve this if it sounds good to you!

svenwltr commented 4 months ago

Hello! This was released in a minor update release, but it would break all our apps, since we are using KeyDB and as far as I see it does not support CLIENT SETINFO.

Looking at the references to this PR, we are not the only ones having issues.

Are there plans for fixing this or workarounds available?

SlevinWasAlreadyTaken commented 4 months ago

Same for me, I think there is a regression or a breaking change. I run into this error while calling redis client.Ping: ERR unknown subcommand 'setinfo'. Try CLIENT HELP.

homme commented 4 months ago

Follow #2911 if you've found your way here because this change is breaking your apps.