bug: Fix SETINFO ensuring it is set-and-forget

redis / go-redis

Redis Go client

https://redis.uptrace.dev

BSD 2-Clause "Simplified" License

19.61k stars 2.31k forks source link

bug: Fix SETINFO ensuring it is set-and-forget #2915

Closed ofekshenawa closed 4 months ago

ofekshenawa commented 4 months ago

Updating SETINFO so that when it is sent, it is set-and-forget. This enabled SETINFO to run only where appropriate (i.e redis 7.2+). Once ready, this release should:

closes #2910 closes #2911 closes #2914

git-hulk commented 4 months ago

@ofekshenawa How about disabling identity by default as mentioned in https://github.com/redis/go-redis/pull/2880#issuecomment-1951063051? guess most of the users are running Redis < 7.2 and enabling this may affect the performance of the connect stage.