search

redis / hiredis-node

Node wrapper for hiredis
BSD 3-Clause "New" or "Revised" License
305 stars 84 forks source link

0.4.0 fails with iojs v3.0.0 #95

Closed taoeffect closed 9 years ago

taoeffect commented 9 years ago

I'm not sure whether this is related to #94, but I know this:

See the full error/build log here:

https://travis-ci.org/okTurtles/dnschain/jobs/74161603

badboy commented 9 years ago

Gnaaah, they keep breaking nan with new io.js releases. Upgrading nan should do the trick.

badboy commented 9 years ago

Except that nan 2 breaks lots of other stuff. I put this on my todo, hopefully until the end of the week.

badboy commented 9 years ago

Guess this have to wait for a bit. There is no documentation on the upgrade process for NAN v2 (yet).

taoeffect commented 9 years ago

Are we sure this issue is fixed?

Travis still erroring with it: https://travis-ci.org/okTurtles/dnschain/jobs/77775121

badboy commented 9 years ago

Atleast our own build didn't fail: https://travis-ci.org/redis/hiredis-node/jobs/76797442

I'll look into this tomorrow.

badboy commented 9 years ago

@taoeffect I can't reproduce it locally. It builds just fine for me with the latest io.js. Even a npm install in your dnschain project works (after changing it to latest hiredis-node, not sure where your commit for this ended up)

taoeffect commented 9 years ago

@badboy This appears to be due to a difference between our .travis.yml files. Yours explicitly installs g++-4.8, whereas ours uses the default settings.

So, since most people don't customize their .travis.yml file in this way, is it possible to make it work with the defaults? If not, perhaps you can update your README to instruct people that hiredis requires making customizations to .travis.yml?

badboy commented 9 years ago

Thanks for checking, I see what I can do about it.

badboy commented 9 years ago

Latest node/io.js has gcc/g++ 4.8 as a prerequisite. gcc 4.6, which is the default on travis, is more than 3 years old, so moving on seems reasonable.

I will add it to the readme.

taoeffect commented 9 years ago

Awesome, thanks @badboy!

NicolasRitouet commented 9 years ago

I had the same issue on CircleCI with hiredis 0.4.1 on node 4.2.0. Adding this to circle.yml fixed the problem:

machine:
  pre:
    - sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.6 10
    - sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-4.6 10
    - sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.9 20
    - sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-4.9 20

Thanks @badboy