search

redis / hiredis-rb

Ruby wrapper for hiredis
BSD 3-Clause "New" or "Revised" License
319 stars 90 forks source link

Bump hiredis to v1.0.0 #69

Closed artygus closed 2 years ago

artygus commented 3 years ago

According to hiredis readme, there's only a handful of breaking changes.

https://github.com/redis/hiredis/blob/297f6551da11d4a22fefe4d385d42edf27a6cd73/README.md

IMPORTANT: Breaking changes from 0.14.1 -> 1.0.0

redisContext has two additional members (free_privdata, and privctx).
redisOptions.timeout has been renamed to redisOptions.connect_timeout, and we've added redisOptions.command_timeout.
redisReplyObjectFunctions.createArray now takes size_t instead of int for its length parameter.

This PR:

ssinghi commented 2 years ago

@rafaelfranca @michael-grunder can it please get some love. Thank you so much!

michael-grunder commented 2 years ago

I have the ability to merge this PR and am happy to do so.

That said, I know next to nothing about Ruby so may need some help with any issues that may arise after we merge.

kimyu92 commented 2 years ago

@michael-grunder can we get this merge first then we can update to 1.0.2

michael-grunder commented 2 years ago

Merged, thank you.

stanhu commented 2 years ago

@michael-grunder Do you need help with maintaining this project? I'd like to help. I see that hiredis has not had a Ruby release since 2018. A number of us at GitLab are interested in using hiredis in production, but without SSL support in an actual release we're going to hold off.

michael-grunder commented 2 years ago

Hi, @stanhu, that would be great!

I'm happy to facilitate the releases (merging PRs, tagging, etc) and can help with any changes that are required in upstream hiredis, but I have almost no knowledge of Ruby at all, so some added expertise there would be fantastic.

stanhu commented 2 years ago

@michael-grunder Great! Could you tag a release to start? I think https://github.com/redis/hiredis-rb/pull/59 is pretty important as well, but we should probably re-trigger CI if available.

michael-grunder commented 2 years ago

Sure, I can do that over the weekend.

stanhu commented 2 years ago

I suppose a 1.0.0 release should actually support SSL: https://github.com/redis/hiredis-rb/issues/58

michael-grunder commented 2 years ago

Yeah, it would seem prudent :smile:. I honestly forgot about taking a crack at the implementation.

Also, I've requested that the folks at Redis Inc add you as a maintainer to this project. I think @chayim might be taking point on that.